dev: return deployed contract address in get_transaction_receipt api

[tonypony220]

Pull Request type

What is the current behavior?

return zeros

Resolves: #1095
Resolves: #1111

What is the new behavior?

• runtime api exposes new method to get fee disabled config is_transaction_fee_disabled
• runtime api exposes new method to get transaction from block extrinsics get_index_and_tx_for_tx_hash
• runtime api refactor get_events just by id fn get_events_for_tx_by_index(tx_index: u64) -> Option<Vec<StarknetEvent>>

---

get_transaction_receipt changes:

• get actual_fee from Transfer event if fee not fee_disabled
• in case DeployAccount transaction calculates contract_address , cause searching it in events is errorprone

Does this introduce a breaking change?

No

Other information

[tonypony220]

I'm not entirely sure about this logic because I need to delve deeper into events. Still, if someone can take a look and share advice, it would be awesome.

[tonypony220]

@EvolveArt can you maybe take a look?

[EvolveArt]

Overall lgtm.

We should create an issue to deal with the deploy_account edge case mentionned in the PR's comments.
Maybe in the future we can also find a more efficient way than looking at the events to retrieve this information.

[tdelabro]

@tonypony220 are you still making progresses on this one?

[tonypony220]

@tonypony220 are you still making progresses on this one?

Yeap!