Temporary: Improve external usability #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2024
notlesh
changed the title
|
Closing as is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #364
Type
Description
This PR implements the easiest path to making SNOS and
prove_blockusable externally as needed in #364. It does so by making two easy trade-offs:Including OS build artifacts (committing
build/os_latest.json) - a98e1b0This prevents
include_bytes!("../../../build/os_latest.json");from failing without introducing a lot of complexity in build automation, but now we have an artifact to manage which will likely cause confusion, unintended changes, etc.Alternatives I explored could include pyO3 or building with docker. Either might work, but would come with a lot of build complexity, maintenance, etc.
Converting
RctoArc- db898dcThis is probably not controversial, although it does come with some overhead. The overhead probably doesn't appear in any hot path, although I don't have a good way to measure this.
Breaking changes?