Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle contract commitments for contract without data items #388

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

whichqua
Copy link
Collaborator

Problem: reexecution panics when a contract doesnt have data items

Solution: handle the edge case to prevent panics

Requires #387 and Moonsong-Labs/pathfinder#2

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

Problem: reexecution panics when a contract doesnt have data items

Solution: handle the edge case to prevent panics
Copy link
Collaborator

@HermanObst HermanObst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration test showing the issue was fixed

@whichqua whichqua force-pushed the gm/internal-error-tree-height branch from 2005edc to b5d131d Compare October 2, 2024 12:15
@whichqua
Copy link
Collaborator Author

whichqua commented Oct 2, 2024

Please add integration test showing the issue was fixed.

@HermanObst this branch targets gm/no-possible-convertion where I have added two previously failing blocks. The issue came up when I fixed the conversion issue, I had created a new branch thinking it was unrelated. I hope to merge to that PR then merge to main with those tests. Let me know if that works.

@HermanObst HermanObst merged commit 0c13f1c into gm/no-possible-convertion Oct 2, 2024
6 checks passed
@HermanObst HermanObst deleted the gm/internal-error-tree-height branch October 2, 2024 14:39
whichqua added a commit that referenced this pull request Oct 3, 2024
HermanObst pushed a commit that referenced this pull request Oct 4, 2024
HermanObst added a commit that referenced this pull request Oct 14, 2024
* fix: improve convertion errors to provide more context

* fix: better error handling and fix for invalid abi

* fix: add tests for blocks, and minor fixes based on review

* fix: handle contract commitments for contract without data items (#388)

* fix: handle contract commitments for contract without data items

Problem: reexecution panics when a contract doesnt have data items

Solution: handle the edge case to prevent panics

* fix: only one commitment return

* Revert "fix: handle contract commitments for contract without data items (#388)" (#394)

This reverts commit 0c13f1c.

---------

Co-authored-by: Herman Obst Demaestri <[email protected]>
matzayonc pushed a commit to matzayonc/snos that referenced this pull request Oct 15, 2024
…strange#387)

* fix: improve convertion errors to provide more context

* fix: better error handling and fix for invalid abi

* fix: add tests for blocks, and minor fixes based on review

* fix: handle contract commitments for contract without data items (keep-starknet-strange#388)

* fix: handle contract commitments for contract without data items

Problem: reexecution panics when a contract doesnt have data items

Solution: handle the edge case to prevent panics

* fix: only one commitment return

* Revert "fix: handle contract commitments for contract without data items (keep-starknet-strange#388)" (keep-starknet-strange#394)

This reverts commit 0c13f1c.

---------

Co-authored-by: Herman Obst Demaestri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants