[Not merge] Statistics script #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: there is a bug in this function causing us to miss some edge bottom nodes, resulting in "Edge not found in preimage" bugs. Solution: the bitmask needs to clear all the bits corresponding to the edge, which can only be achieved with an `& 0x0` type of operation (and not `& ~mask`. Additionally, the height was inverted compared to the rest of the OS (0 is supposed to be the height of leaf nodes, not the height of the root), this PR fixes this.
Problem: there is a bug in cairo-vm that causes the `dest_ptr` variable in `segment_arena.cairo` to be set to 0 (felt) instead of a relocatable. Solution: add a workaround that computes the correct value instead of getting it from the Cairo code.
Co-authored-by: Stephen Shelton <[email protected]>
* fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: N/A
Type
Description
Breaking changes?