fix: timestamp and block number mismatch #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsasari
reviewed
Oct 9, 2024
| @@ -136,9 +137,11 @@ where | |||
| let syscall_handler = self.deprecated_syscall_handler.read().await; | |||
|
|
|||
| let block_number = syscall_handler.block_info.block_number; | |||
| let rounded_block_number = (block_number.0 / VALIDATE_BLOCK_NUMBER_ROUNDING ) * VALIDATE_BLOCK_NUMBER_ROUNDING; | |||
There was a problem hiding this comment.
Can you use prev_multiple_of instead?
notlesh
reviewed
Oct 9, 2024
| @@ -15,6 +15,7 @@ use crate::cairo_types::syscalls::{ | |||
| TxInfo, | |||
| }; | |||
| use crate::starknet::starknet_storage::PerContractStorage; | |||
| use crate::execution::constants::{VALIDATE_BLOCK_NUMBER_ROUNDING, VALIDATE_TIMESTAMP_ROUNDING}; | |||
There was a problem hiding this comment.
We already discussed this, but these should be able to come from the constants in cairo-lang. We should do that if at all possible, but if not we should leave a comment about that here.
notlesh
reviewed
Oct 15, 2024
| let execution_info_ptr = execution_helper | ||
| .call_execution_info_ptr | ||
| .ok_or(HintError::SyscallError("Execution info pointer not set".to_string().into_boxed_str()))?; | ||
| let block_info_pointer = vm.get_relocatable((execution_info_ptr + ExecutionInfo::block_info_offset())?)?; |
There was a problem hiding this comment.
Super nit: we usually _ptr instead of _pointer
notlesh
reviewed
Oct 15, 2024
notlesh
reviewed
Oct 15, 2024
| let tx_version = TransactionVersion::ZERO; | ||
| let tx_version = TransactionVersion::THREE; |
There was a problem hiding this comment.
I am also curious about this.
notlesh
approved these changes
Oct 15, 2024
Co-authored-by: Stephen Shelton <[email protected]>
whichqua
approved these changes
Oct 15, 2024
| let tx_version = TransactionVersion::ZERO; | ||
| let tx_version = TransactionVersion::THREE; |
There was a problem hiding this comment.
I am also curious about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Some blocks were failing because the get_block_number and get_block_timestamp were retrieving different values than the SNOS was expecting.
This is related to the fact that two modes of execution exist: Execute (were the expected behaviour is to get the actual block number and timestamp) and Validate (were the expectation is to get an rounding of them)
Fix: modify the given syscalls to fetch the blockInfo from the ExecutionInfo struct from SNOS