Pre-release versioning #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HermanObst
requested changes
Dec 27, 2024
There was a problem hiding this comment.
@notlesh some thoughts:
- I would change the version to v0.1.0 (not v1.0.0)
- The cairo-lang submodule shouldn't be modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares SNOS for its first release by bumping each crate's version to
1.0.0-dev. It's also a suggestion on how to implement versioning based on Semver.Each crate is independently versioned. This is so changes to one crate don't create noise for the users of other crates.
I also suggest adopting
-devtag to indicate a pre-release version. This is inspired by other projects like Frontier. It's explained well there, but to summarize: appending-devto the version string flags the version as in the process of being bumped in the next release, making it easier to understand when and how a PR should bump the version.Issue Number: N/A
Type
Breaking changes?