Add support to Pathfinder v0_8 #456
Conversation
| #[case::missing_constant_max_high(164684)] | ||
| #[case::retdata_not_a_relocatable(160033)] | ||
| #[case::get_tx_info_using_ptr_over_relocatable(243766)] | ||
| #[case::small_block_with_only_invoke_txs(76793, "v0_7")] |
There was a problem hiding this comment.
Does this mean these tests cannot be run on v0.8?
There was a problem hiding this comment.
They should be able to run on v0_8, but they were not made for that, therefore I left them using the old version to maintain their original purpose and added new tests (that repeat some of the old tests that had errors when first developing) on the new api.
There was a problem hiding this comment.
I think that it would be good to have a default variable that is set to "v0_7" and maybe put all the "v0_8" tests in a different file / different test. So, once the v0.8 is working for all the tests, we can just replace the default. Besides, it's a little bit cleaner
There was a problem hiding this comment.
@GMKrieger for this PR we may also take in account that we only have one proof now for all the keys, instead of individual proofs, which should change the verification function according to that to accept the union path returned by the RPC call.
GMKrieger
force-pushed
the
feat/pathfinder_v0_8
branch
from
65f0c56 to
08ba11a
Compare
| #[case::missing_constant_max_high(164684)] | ||
| #[case::retdata_not_a_relocatable(160033)] | ||
| #[case::get_tx_info_using_ptr_over_relocatable(243766)] | ||
| #[case::small_block_with_only_invoke_txs(76793, "v0_7")] |
There was a problem hiding this comment.
I think that it would be good to have a default variable that is set to "v0_7" and maybe put all the "v0_8" tests in a different file / different test. So, once the v0.8 is working for all the tests, we can just replace the default. Besides, it's a little bit cleaner
GMKrieger
force-pushed
the
feat/pathfinder_v0_8
branch
from
08ba11a to
3f291a9
Compare
Issue Number: N/A
Type
Description
Adds support for pathfinder v0_8. It coalesces the 2 types of request on the client and then converts the new version to the one supported by snos.
Breaking changes?