Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : token details form #272

Merged
merged 6 commits into from
Aug 22, 2024
Merged

feat : token details form #272

merged 6 commits into from
Aug 22, 2024

Conversation

Jemiiah
Copy link
Contributor

@Jemiiah Jemiiah commented Jul 28, 2024

issue: #242

@vercel Vercel
Copy link

vercel bot commented Jul 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unruggable-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 0:29am

@vercel Vercel
Copy link

vercel bot commented Jul 28, 2024

@Jemiiah is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@Jemiiah Jemiiah marked this pull request as ready for review July 28, 2024 19:00
@Jemiiah
Copy link
Contributor Author

Jemiiah commented Jul 28, 2024

please kindly review this work

@ugur-eren ugur-eren self-requested a review August 5, 2024 22:36
ugur-eren
ugur-eren requested changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested a change, which is a blocking issue, it should be fixed.
Also, the design should match the site itself, please re-design it so it matches.

resim

packages/frontend/src/pages/Token/Communities.tsx Outdated Show resolved Hide resolved
packages/frontend/src/pages/Token/index.tsx Outdated Show resolved Hide resolved
@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 6, 2024

@ugur-eren please check again

@ugur-eren
Copy link
Collaborator

@Jemiiah linting issues are still present in the frontend, also please revise the design of the form so it matches the application itself.

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 7, 2024

@ugur-eren is there any way to see the page because we don’t have a deployed token yet is there any work, I can use to see page as I do the design

@ugur-eren
Copy link
Collaborator

You can temporarily disable the is owner check and see your form. You can use any launched token, for example PAL 0x049201f03a0f0a9e70e28dcd74cbf44931174dbe3cc4b2ff488898339959e559

@Jemiiah Jemiiah requested a review from ugur-eren August 21, 2024 07:56
ugur-eren
ugur-eren approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, LGTM!

@ugur-eren ugur-eren requested a review from 0xChqrles August 22, 2024 07:20
0xChqrles
0xChqrles approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@0xChqrles 0xChqrles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xChqrles 0xChqrles merged commit e1eda38 into keep-starknet-strange:main Aug 22, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ugur-eren ugur-eren ugur-eren approved these changes

@0xChqrles 0xChqrles 0xChqrles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jemiiah @ugur-eren @0xChqrles