feat: add optional trace to CairoVM struct and add enable trace flag #23
Conversation
src/vm/core.zig
Outdated
| } | ||
| } | ||
|
|
||
| // TODO: Find a valid Instruction so we can call `runInstruction` to check if traces |
There was a problem hiding this comment.
remove commented test and create an issue with the content of this test instead please
There was a problem hiding this comment.
I am wondering if we should just make the config struct of the cmd in a config.zig file and share it between the cli and the core vm.
Instead of passing individual flags like we do in this PR.
I am worried that it will be harder to maintain if each time we add a new flag in the init function and a new field in the VM.
For example we see here that you had to change each individual test to add the new parameter.
If it was the struct and if the struct has a default function you would not have to change the tests most of the time, only when you need to change the config for an actual test.
|
reopened: #27 |
|
Pull Request closed and locked due to lack of activity. |
Fixes: #9
I am new to zig so let me know if something is non idiomatic or there is a better way to do it.