perf(vm): use dynamic dispatch to enable/disable tracing of instructions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This remains in draft until I can figure out whether this is a regression or not :) This kind of optimization is really hard to predict. |
|
Pull Request closed and locked due to lack of activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dynamic dispatch mechanism to trace instructions within the VM.
This is related to #25.
Performance Considerations
I'm not yet sure whether a function pointer call is that slower or faster than a regular if/else branch. The CPU might be able to optimze the latter better because of its knowledge of the content. With this PR, we might've just removed any optimization possibility entierly.
This should be benchmark to avoid regressions.