feat: client connection logic #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xChqrles
requested changes
Aug 29, 2024
There was a problem hiding this comment.
why does the yarn.lock file has to change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the connection logic, just calling the extension API in the webpage
it's just returning mock data, but it's not hard to implement in the extension the function to open the side panel and do the proving process, but I forgot to put everything in the same PR, and now I will mess up everything if I change this detail in this PR.
I can modify the function extract data to get the Revolut ID and also I can allow the extension to read all the requests from web, just assigning me to these issues :).
If I need to modify anything I'm here, I implemented in a abstract way