Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test add liquidity #95

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

chachaleo
Copy link
Contributor

Resolves: #83

  • Implementation of the add_liquidity tests
  • fix : add initiate_liquidity_retrieval to ZKRampABI
  • fix : unlock liquidity in add_liquidity

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zkramp-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:18am
zkramp-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:18am

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (b66caff) to head (bb0a064).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #95       +/-   ##
===========================================
+ Coverage   42.50%   66.14%   +23.64%     
===========================================
  Files          11       11               
  Lines         120      127        +7     
===========================================
+ Hits           51       84       +33     
+ Misses         69       43       -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xChqrles

This comment was marked as resolved.

Copy link
Contributor

@0xChqrles 0xChqrles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing 🤓

@0xChqrles 0xChqrles merged commit 74c8e3b into keep-starknet-strange:main Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CONTRACTS] implement add_liquidity tests
2 participants