Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filling Credit Card information #1614

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Apr 24, 2022

  • Adds basic detection for credit card forms
  • Adds a new icon for filling credit card information from the name field

Currently the following KPH attributes are supported in this WIP branch:

KPH: CC_CCV
KPH: CC_EXP
KPH: CC_EXP_MONTH
KPH: CC_EXP_YEAR
KPH: CC_NAME
KPH: CC_NUMBER
KPH: CC_TYPE

TODO:

  • CC_EXP and CC_TYPE are not yet used/filled.
  • Attributes used above should be properly defined. What attributes are the other KeePass clients using for their templates?
  • Credit Card information should be stored to one entry. When trying to fill the information using the icon, KeePassXC could ask "Do you want to allow this site to fill Credit Card information?" and then add the site URL to entry's Additional URL's list.

@varjolintu varjolintu marked this pull request as draft April 24, 2022 09:04
@varjolintu varjolintu changed the title First draft Allow filling Credit Card information Apr 24, 2022
@droidmonkey
Copy link
Member

I dunno how I feel about extending the KPH: syntax. I don't have a better alternative right now though.

@varjolintu
Copy link
Member Author

varjolintu commented Apr 24, 2022

I dunno how I feel about extending the KPH: syntax. I don't have a better alternative right now though.

Yeah. I don't prefer it either, but at least this draft can be tested with them because it doesn't need any code changes to KeePassXC side.
We already use KP2A_URL so it could be logical to name these as KP2A_CC_NAME etc.

@droidmonkey
Copy link
Member

droidmonkey commented Apr 24, 2022

That prefix is also challenged because it prefers a specific solution (KeePass2Android). The custom entry layouts will likely not prefer any prefix. The solution should be structured such that no prefix is required at all, you would map chosen attributes to their function.

@varjolintu
Copy link
Member Author

I'd suggest that when the template implementation is ready on KeePassXC side, get-logins should return an extra array templates with the usual entries. That would keep them separate from normal credentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants