Fix Visual Studio install detection in release-tool.ps1 #10101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saw that this was fixed in another branch. I will close |
|
Will reopen for now, might be useful since the fix in the other branch involves manually installing a powershell module |
ultralapse
changed the title
ultralapse
referenced
this pull request
Dec 14, 2023
* Requires `Install-Module VSSetup -Scope CurrentUser` to be run before using the release tool. * The latest version of Visual Studio 2022 removes the ability to find itself with WIM (the previous method)
|
This is nuts, they changed it without any documentation (I'm not surprised it's microsoft...) |
|
Hmmm, I had referenced this article before, looks like they recently added the namespace flag. Yup it was added mid october: MicrosoftDocs/visualstudio-docs@46e97eb |
droidmonkey
approved these changes
Dec 19, 2023
|
I'll have to sign the release script before merge, no need to merge develop into this |
`Get-CimInstance MSFT_VSInstance` does not always work as it uses the default namespace root/cimv2. Specifying `Get-CimInstance MSFT_VSInstance -Namespace root/cimv2/vs` allows it to work. I have included a try catch block to only explictly specify the namespace if the default command fails.
Removed try catch block, clearly the Get-CimInstance MSFT_VSInstance doesn't work
droidmonkey
added a commit
that referenced
this pull request
Jan 27, 2024
* Update release-tool.ps1 `Get-CimInstance MSFT_VSInstance` does not always work as it uses the default namespace root/cimv2. Specifying `Get-CimInstance MSFT_VSInstance -Namespace root/cimv2/vs` allows it to work. Co-authored-by: Jonathan White <[email protected]>
pull bot
pushed a commit
to mengzhisuoliu/keepassxc
that referenced
this pull request
Jan 27, 2024
…ot#10101) * Update release-tool.ps1 `Get-CimInstance MSFT_VSInstance` does not always work as it uses the default namespace root/cimv2. Specifying `Get-CimInstance MSFT_VSInstance -Namespace root/cimv2/vs` allows it to work. Co-authored-by: Jonathan White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-CimInstance MSFT_VSInstancedoesn't work for all Windows and Visual Studio installs as it uses the default namespaceroot/cimv2.Get-CimInstance MSFT_VSInstance -Namespace root/cimv2/vsshould workScreenshots
Circled red is the
Get-CimInstance MSFT_VSInstancecommand not workingCircled green is the
Get-CimInstance MSFT_VSInstance -Namespace root/cimv2/vscommand working.Testing strategy
The script ran successfully in powershell after the edits were made.
Type of change