Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Qt6 transition #11651

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Conversation

varjolintu
Copy link
Member

Continues work from #10267, using #11003 as the base.

Fixes #7774.

Type of change

  • ✅ Refactor (significant modification to existing code)

droidmonkey and others added 10 commits January 2, 2025 23:38
* Remove individual feature flags in favor of a single `KPXC_MINIMAL` flag that removes advanced features from the build. Basic features are no longer guarded by feature flags.
* Basic features: Auto-Type, Yubikey, KeeShare
* Advanced features include: Browser (and passkeys), SSH Agent, and Secret Service
* Networking, Documentation, and Update Checking remain as feature flags to accommodate various distro requirements.

This change also cleans up the main CMakeLists.txt by re-arranging some content and placing macros into a dedicated include file. The minimum CMake version was bumped to 3.16.0 to conform to our minimum Ubuntu support of Focal (20.04). This also allows us to default to C++20, we fall back to C++17 for Qt versions less than 5.15.0 due to lack of support.

Lastly this change removes the KEEPASSXC_BUILD_TYPE="PreRelease" which is never used. We only support "Snapshot" and "Release" now.
- Fix missing X11 library for linker
- Other Linux fixes

NOTE: FDOSECRETS CURRENTLY CRASHES WHEN ATTEMPTING TO BE USED
@varjolintu varjolintu added pr: refactoring Pull request that refactors code Qt labels Jan 12, 2025
@varjolintu varjolintu added this to the v2.8.0 milestone Jan 12, 2025
@varjolintu varjolintu mentioned this pull request Jan 12, 2025
7 tasks
@varjolintu varjolintu changed the title Qt6 ver2 WIP: Qt6 transition Jan 12, 2025
droidmonkey and others added 2 commits January 12, 2025 09:38
* Also reduce minimum Qt version to 6.4.2 to align with Ubuntu 24.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority 🚨 pr: refactoring Pull request that refactors code Qt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt 6 upgrade
2 participants