Add support to get process name on FreeBSD #9980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it possibly be worth pulling this into NixUtils? |
|
I was thinking that same thing, but fdo secrets is already a 'nix only service. The only benefit would be repeatability, but we don't need other process names anywhere else atm. |
|
Anything I can do so that someone have a look ? |
droidmonkey
approved these changes
Dec 21, 2023
|
You need to run clang-format on the file you changed then recommit |
|
Done, sorry I should have done the clang-format before submitting in the first place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD there is no such thing as /proc/* so right now when a process request a the dialog UI show a cryptic /proc/pid/exe, with the change is shows the proper path of the process.
Testing strategy
I tested with nheko and nextcloud desktop client, when they start, they both request a password to the fdosecret store, which makes keepassxc popup a dialog saying /proc//exe is requesting a password, after the change it is replace with the proper path.
Type of change