Auto-discover Home Assistant when running inside an add-on #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should be able to get rid of these lines once this is merged. |
7 tasks
frenck
reviewed
Feb 20, 2025
| @@ -54,6 +54,10 @@ export class ConfigurationService implements IConfigurationService { | |||
| if (!this.token && process.env.HASS_TOKEN) { | |||
| this.token = process.env.HASS_TOKEN; | |||
| } | |||
| if (!this.url && !this.token && process.env.SUPERVISOR_TOKEN) { | |||
There was a problem hiding this comment.
This is what the above HASS_SERVER & HASS_TOKEN originally tried to solve.
That said, not against this addition as it allows a little clean up on the add-on part.
../Frenck
There was a problem hiding this comment.
@frenck, only the VS Code add-on exposes HASS_SERVER and HASS_TOKEN. This change is mainly for other add-ons, like Advanced Terminal.
There was a problem hiding this comment.
Yeah I get that, but I can clean that part up after this one 😉
frenck
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-ons have
SUPERVISOR_TOKENset as environment variable (for example Terminal add-on when running from VS Code Remote SSH. But even the regular VS Code add-on should have it.