Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.URL deprecated,and .RSSLink deprecated on v 0.55 #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nonumeros
Copy link

There are quite a few changes coming up with hugo v 0.55

Page's .URL is deprecated and will be removed in a future release. Use .Permalink or .RelPermalink. If what you want is the front matter URL value, use .Params.url.

Page's .RSSLink is deprecated and will be removed in a future release. Use the Output Format's link, e.g. something like: {{ with .OutputFormats.Get "RSS" }}{{ . RelPermalink }}{{ end }}.

this pull request fixes it for you. I just tested your theme and it's working.

@keichi
Copy link
Owner

keichi commented Apr 17, 2019

@nonumeros Thanks! Is this backward compatible?

@nonumeros
Copy link
Author

Helloi @keichi let me check again for yours. How far back do you need it?

@keichi
Copy link
Owner

keichi commented Apr 17, 2019

Hey, it's fine if it only works with v0.55. I just want to clarify the minimum required version of hugo in README and theme.toml.

@keichi
Copy link
Owner

keichi commented Apr 17, 2019

The RSS link in the header seems to be broken. Can you take a look?

@nonumeros
Copy link
Author

The RSS link in the header seems to be broken

I'll check it

@nonumeros
Copy link
Author

@keichi double check the RSS for me. Thanks. Can't believe I missed that one.

@nonumeros
Copy link
Author

the <a href attribute for the RSS is the tricky part.

But see for example https://github.com/Lednerb/bilberry-hugo-theme/blob/master/exampleSite/config.toml

in which he @Lednerb already specified the parameters on the config file from the exampleSite

 [outputs]
    home = [ "HTML", "JSON", "RSS" ]

Anything else @keichi for his use case to have RSS on the site, such as .OutputGetFormats.Get blah blah is superfluous. Of course, one can still have it in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants