fix: ValidationError as value (#16)

Signed-off-by: Alfredo Garo <[email protected]>

README.md

@@ -119,7 +119,7 @@ The `error` returned by `Validate()` has structured data with information on the
 ``` golang
 v := validator.NewValidator(client, spec)
 err := v.Validate()
-if vErr, ok := err.(*validator.ValidationError); ok {
+if vErr, ok := err.(validator.ValidationError); ok {
 
   fmt.Printf("Validation failed for %s/%s/%s.\n",
     vErr.GVR.Group, vErr.GVR.Version, vErr.GVR.Resource)

pkg/client/types.go

@@ -118,7 +118,7 @@ type ValidationError struct {
 	ConditionValidations []ConditionValidationResult
 }
 
-func (e *ValidationError) Error() string {
+func (e ValidationError) Error() string {
 	fieldValidationResult, _ := json.MarshalIndent(e.FieldValidations, "", "\t")
 	conditionValidationResult, _ := json.MarshalIndent(e.ConditionValidations, "", "\t")
 	return fmt.Sprintf("%v.\nGVR: %s/%s/%s.\nField Validation Results: %s\nCondition Validation Results: %s", e.Message,

pkg/client/validator.go

@@ -83,7 +83,7 @@ func (v *Validator) Validate() error {
 						prettyPrintStruct(summary)
 					}
 					if r.Required {
-						v.Waiter.errors <- &ValidationError{
+						v.Waiter.errors <- ValidationError{
 							Message:              errors.Errorf("failure threshold met for resource '%v'", resourceName),
 							GVR:                  groupVersionResource(r.APIVersion, r.Name),
 							FieldValidations:     summary.FieldValidation,