Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics implementation #29

Merged
merged 4 commits into from
Dec 2, 2019

Conversation

eytan-avisror
Copy link
Collaborator

Fixes #10

This PR adds the following metrics to /metrics endpoint:

# HELP process_active_goroutines indicates the current number of active goroutines.
# TYPE process_active_goroutines gauge
process_active_goroutines 6
# HELP process_average_duration_seconds indicates the average duration of processing a hook in seconds.
# TYPE process_average_duration_seconds gauge
process_average_duration_seconds 0
# HELP process_deregistering_instances_count indicates the current number of deregistering instances.
# TYPE process_deregistering_instances_count gauge
process_deregistering_instances_count 0
# HELP process_draining_instances_count indicates the current number of draining instances.
# TYPE process_draining_instances_count gauge
process_draining_instances_count 0
# HELP process_failed_events_total indicates the sum of all failed events.
# TYPE process_failed_events_total counter
process_failed_events_total 0
# HELP process_failed_lb_deregister_total indicates the sum of all events that failed to deregister loadbalancer.
# TYPE process_failed_lb_deregister_total counter
process_failed_lb_deregister_total 0
# HELP process_failed_node_drain_total indicates the sum of all events that failed to drain the node.
# TYPE process_failed_node_drain_total counter
process_failed_node_drain_total 0
# HELP process_rejected_events_total indicates the sum of all rejected events.
# TYPE process_rejected_events_total counter
process_rejected_events_total 0
# HELP process_successful_events_total indicates the sum of all successful events.
# TYPE process_successful_events_total counter
process_successful_events_total 0
# HELP process_successful_lb_deregister_total indicates the sum of all events that succeeded to deregister loadbalancer
# TYPE process_successful_lb_deregister_total counter
process_successful_lb_deregister_total 0
# HELP process_successful_node_drain_total indicates the sum of all events that succeeded to drain the node.
# TYPE process_successful_node_drain_total counter
process_successful_node_drain_total 0
# HELP process_terminating_instances_count indicates the current number of terminating instances.
# TYPE process_terminating_instances_count gauge
process_terminating_instances_count 0

@eytan-avisror eytan-avisror requested a review from a team as a code owner November 28, 2019 18:54
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #29 into master will increase coverage by 0.36%.
The diff coverage is 83.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   80.06%   80.42%   +0.36%     
==========================================
  Files           8        9       +1     
  Lines         657      746      +89     
==========================================
+ Hits          526      600      +74     
- Misses         90      100      +10     
- Partials       41       46       +5
Impacted Files Coverage Δ
pkg/service/metrics.go 100% <100%> (ø)
pkg/service/types.go 60% <38.46%> (-8.75%) ⬇️
pkg/service/server.go 77.19% <81.81%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb028e...e7a5aba. Read the comment docs.

@eytan-avisror eytan-avisror merged commit bfe92b0 into keikoproj:master Dec 2, 2019
@eytan-avisror eytan-avisror deleted the prometheus branch December 2, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support prometheus/metrics endpoint
2 participants