ports/posix: Allow building with -static, skipping readline #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, $ make STATIC=1 will build the posix snek port as a static executable. It seems that libreadline doesn't like to be used with static executables because it wants to dlopen some helper libaries. To work around this, just skip readline in this case. Signed-off-by: Keith Packard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch,
will build the posix snek port as a static executable.
It seems that libreadline doesn't like to be used with static executables because it wants to dlopen some helper libaries. To work around this, just skip readline in this case.
See issue #38 for a possible use case.
Signed-off-by: Keith Packard [email protected]