Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias support #27

Merged
merged 2 commits into from
Sep 30, 2017
Merged

Alias support #27

merged 2 commits into from
Sep 30, 2017

Conversation

sgravrock
Copy link
Contributor

Fixes #8.

@sgravrock
Moved list of signoff commands into GitTogether
c675c7d
@sgravrock
Added support for aliases. Fixes kejadlen#8.
320ca61 
Supported aliases are pulled from the git-together.aliases config
variable, which (if set) should be a comma-separated list of aliases
e.g. "ci,rv,m".

Signed-off-by: Steve Gravrock <[email protected]>
@kejadlen kejadlen merged commit 6b10269 into kejadlen:master Sep 30, 2017
@kejadlen
Copy link
Owner

In hindsight, this might need some more configuration due to issues like #26, but it's a step in the right direction.

@kejadlen kejadlen mentioned this pull request Sep 30, 2017
Closed
@kejadlen
Copy link
Owner

Although I just realized that there's now issues if GitTogether::new() fails, since that will block git in general, which is undesirable. Probably should make GitTogether::new() always return and just no-op stuff past that that relies on authors, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgravrock @kejadlen