add Camera settings #42

ldlac · 2023-04-05T21:38:56Z

inspired from this awesome library https://github.com/free5lot/Camera_Net

ldlac · 2023-04-05T21:40:25Z

FlashCap.Core/Internal/NativeMethods_DirectShow.cs

+
+            for (int i = 0; i < cElems; i++)
+            {
+#pragma warning disable CS0618


I can't find a way to call the Marshal.<T> ones

I am extremely late in responding due to a lot of private work. My apologies 😵‍💫

Is it correct that what you want to do here is to copy the GUID structure pointed to by pElems into an array and return it? If so, how about this code for example?

public unsafe Guid[] ToGuidArray() { var retval = new Guid[cElems]; fixed (Guid* pr = &retval[0]) { Guid* pd = pr; Guid* ps = (Guid*)pElems; for (var index = 0; index < this.cElems; index++) { *pd = *ps; ps++; pd++; } } return retval; }

We can use the unsafe block in FlashCap, It is used it a lot. (although care must be taken in implementation)

There should have been compatibility between the layout of the GUID structure in native code and the internal layout of the Guid structure in .

kekyo · 2023-04-06T01:03:16Z

@ldlac Thanks for the PR! 😄

I haven't checked the commits yet, but is this implemented to display the DS properties page?
For example, can you have it enumerate a group of DS properties programatically and have it set?

When I looked into this before, I had delved into the possibility of doing something like that. For example:.

Information like public IReadOnlyDictionary<string, Type> device.Properties {get;} could be exposed to FlashCap users.
The user can look at the above dictionary and set the value of the property with device.SetPropertyValue(string name, object? value).

(Whether Type is appropriate or not may require a little more thought.)

If this can be done, not only can the user define their own configuration dialog, but also multi-platform support is possible (e.g., the V4L2 API may also provide the ability to expose and set property values).

Of course, there can and should also be a method to display native property pages (in a platform-specific manner), as in this case. Because there are some poorly implemented DS capture device drivers that do not provide a dictionary of property values and only expose their own property pages.

ldlac · 2023-04-06T02:14:36Z

Thanks for your feedback @kekyo !

My current implementation is surely not ready for FlashCap, I've only implemented it for DS.
I needed to change the Video Standard of a Video Capture USB

I love the idea to expose the properties and be able to display/set them in the proprietary app instead of showing the basic native window.
I'm not sure I'll be able to code this solution thought.

ldlac · 2023-04-06T15:59:43Z

I've also implemented the support of crossbar filter, is this something you want to add to FlashCap?

With the possibility of showing up the property page (ugly native)

kekyo · 2023-04-07T00:41:38Z

In the meantime, please try adding that implementation (if possible, I'd appreciate it if you could finish the current implementation once it's all good and split the commits so it's easier for us to review).
Perhaps some additional work is needed to make it fit the FlashCap API, but we will do that (we will consider whether to merge it once and then make changes or just keep it in this branch).

It would be helpful if you could change the PR branch origin to develop!

ldlac · 2023-04-07T03:02:07Z

FlashCap.Core/Devices/DirectShowDevice.cs

+            && graphBuilder != null
+            && captureGraphBuilder != null)
+        {
+            graphBuilder.FindFilterByName("Capture source", out NativeMethods_DirectShow.IBaseFilter? captureSourceFilter);


in my application (wpf), it's working fine, but in the the sample I've created based on OneShot, I'm getting this
Unable to cast COM object of type 'System.__ComObject' to interface type 'IBaseFilter'.

@kekyo I was currently stuck here, any idea why I'm experiencing this?

OK, I will check it.

@ldlac In this source file, there are 3 places that use FindFilterByName, do all of them throw the same exception? In my environment, the FindFilterByName in DisplayPropertyPage_CaptureFilter also threw an exception.
If so, there may be something wrong with FindFilterByName (I don't know the cause yet). If not, then we need to suspect another cause...

@ldlac I debugged the code and found a problem with the added property page display and the property getter/setter accesses ignoring the COM apartments, so I fixed it.

472f25d (I think the develop was badly positioned and that caused the weird merge (My mistake), so I fixed it in another branch. develop has been repositioned, so please rebase it.)

FlashCap has been modified to initialize another thread as a single-threaded apartment and access DS objects only on it, as past implementation experience has shown that accessing the calling COM apartment as it is causes many frame drops The following is a list of the DS objects that can be accessed beyond the apartment.

When accessing the DS object beyond the apartment, the standard COM way is to marshal the interface, but it is tedious to do this in .NET, so we use SynchronizationContext to send messages. See IndeependentSingleApartmentContext.InvokeAsync().

In the environment at hand, this modification allows the capture filter property page to be displayed.
I have not tested the getter and setter, but the modification should give you an idea of what to do.

Thanks for this commit, really helped!

The sample is working fine, I'll need to handle flags

ldlac · 2023-04-07T03:02:52Z

FlashCap.Core/Devices/DirectShowDevice.cs

@@ -174,7 +175,7 @@ private sealed class SampleGrabberSink :

                    ///////////////////////////////

-                    var captureGraphBuilder = NativeMethods_DirectShow.CreateCaptureGraphBuilder();
+                    captureGraphBuilder = NativeMethods_DirectShow.CreateCaptureGraphBuilder();


I needed a way to access the captureGraph, is there a better way?

@ldlac No problem.

ldlac · 2023-04-07T03:06:20Z

FlashCap.Core/Devices/DirectShowDevice.cs

                    if (captureGraphBuilder.SetFiltergraph(this.graphBuilder) < 0)
                    {
                        throw new ArgumentException(
                            $"FlashCap: Couldn't set graph builder: DevicePath={devicePath}");
                    }

+                    ///////////////////////////////
+
+                    captureGraphBuilder.FindInterface(Guid.Empty, Guid.Empty, captureSource, NativeMethods_DirectShow.IAMVideoProcAmpHelper.GUID, out object? videoProcAmpObject);


on initialize, we can feed the properties dictionary

I've decided to start with IAMVideoProcAmp

I've defined a CaptureDeviceProperty which is implemented for each devices, directshow in this case, the abstraction is based on this one since it's the only one I know of. slightly opiniated.

ldlac · 2023-04-07T03:07:51Z

FlashCap.Core/Devices/DirectShowDevice.cs

                    if (captureGraphBuilder.SetFiltergraph(this.graphBuilder) < 0)
                    {
                        throw new ArgumentException(
                            $"FlashCap: Couldn't set graph builder: DevicePath={devicePath}");
                    }

+                    ///////////////////////////////
+
+                    captureGraphBuilder.FindInterface(Guid.Empty, Guid.Empty, captureSource, NativeMethods_DirectShow.IAMVideoProcAmpHelper.GUID, out object? videoProcAmpObject);


I can't use typeof(IAMVideoProcAmp).GUID because of .netstandard 1.3

any alternative to NativeMethods_DirectShow.IAMVideoProcAmpHelper.GUID ?

@ldlac There is no elegant way to do this, but it can be redefined in the same way as IID_IBaseFilter.

ldlac · 2023-04-07T03:08:30Z

FlashCap.Core/Devices/DirectShowDevice.cs

+                if (videoProcAmpObject != null)
+                {
+                    var videoProcAmp = (NativeMethods_DirectShow.IAMVideoProcAmp)videoProcAmpObject;
+                    videoProcAmp.Get(DirectShowProperty.FromVideoProcessingAmplifierProperty(property), out int value, out NativeMethods_DirectShow.VideoProcAmpFlags _);


I don't really know the use of this one yet, NativeMethods_DirectShow.VideoProcAmpFlags

Even in the environment at hand, I was able to obtain a range of values that we believe to be brightness. Nice work!

ldlac · 2023-04-07T03:09:38Z

FlashCap.Core/Devices/DirectShowProperty.cs

+    {
+        public DirectShowProperty(VideoProcessingAmplifierProperty property, int min, int max, int step) : base(property, min, max, step) { }
+
+        internal static NativeMethods_DirectShow.VideoProcAmpProperty FromVideoProcessingAmplifierProperty(VideoProcessingAmplifierProperty property)


each device property should be able to map from VideoProcessingAmplifierProperty to their own implementation

Perhaps there is a more desirable interface, but this is fine for now 👍

ldlac · 2023-04-07T03:11:58Z

FlashCap.Core/CaptureDevice.cs

@@ -66,6 +66,11 @@ public async Task DisposeAsync()

    protected abstract Task OnStartAsync(CancellationToken ct);
    protected abstract Task OnStopAsync(CancellationToken ct);
+    public abstract void DisplayPropertyPage_CaptureFilter(IntPtr hwndOwner);
+    public abstract int GetPropertyValue(VideoProcessingAmplifierProperty property);
+    public abstract void SetPropertyValue(VideoProcessingAmplifierProperty property, object? value);


eventually SetPropertyValue if more properties are supported, it should receive a wider Type/Enum

Yes, I agree. Perhaps the key that is considered standard is Enum, and we need to consider a separate specifiable interface if the device provides an extended key, but we have not yet figured out how far to abstract it. So we can reserve this issue here.

kekyo · 2023-04-11T01:12:51Z

@ldlac Request when available for review (no rush, go at your own pace)

ldlac · 2023-04-22T16:20:14Z

FlashCap.Core/Internal/NativeMethods_DirectShow.cs

@@ -263,7 +263,7 @@ public interface IEnumFilters
    {
        [PreserveSig] int Next(
            int request,
-            [Out, MarshalAs(UnmanagedType.LPArray, SizeParamIndex=0)] IPin?[] filters,
+            [Out, MarshalAs(UnmanagedType.LPArray, SizeParamIndex=0)] IBaseFilter?[] filters,


I found out this typing error while experimenting

@ldlac Thanks, it is my mistake and your changes are correct.

https://learn.microsoft.com/en-us/windows/win32/api/strmif/nf-strmif-ienumfilters-next

add DisplayPropertyPage_CaptureFilter

109cf15

ldlac commented Apr 5, 2023

View reviewed changes

.

272bb85

kekyo linked an issue Apr 7, 2023 that may be closed by this pull request

change camera settings #14

Open

testing with brightness

510850b

ldlac changed the base branch from main to develop April 7, 2023 02:57

ldlac added 4 commits April 6, 2023 22:59

add DisplayPropertyPage_CaptureFilter

e3d8f0b

.

49bc98c

testing with brightness

84794d1

Merge branch 'main' of https://github.com/ldlac/FlashCap

a0ee273

ldlac commented Apr 7, 2023

View reviewed changes

fill dict

ffd3341

ldlac commented Apr 7, 2023

View reviewed changes

ldlac added 3 commits April 6, 2023 23:15

.

effa8cd

.

4bd01b3

.

85c8830

kekyo assigned ldlac Apr 11, 2023

ldlac and others added 3 commits April 22, 2023 12:04

.

0c4fa11

Fixed invalid cross apartment access at DS pages and properties.

2fdc18b

missing return; sample restore original property value

323758b

ldlac commented Apr 22, 2023

View reviewed changes

kekyo mentioned this pull request May 10, 2023

Add support for video rotation #50

Open

kekyo mentioned this pull request Nov 10, 2023

Added ShowPropertyPage method to DirectShowDevice class #112

Closed

kekyo force-pushed the develop branch 4 times, most recently from 48b9e51 to 5bee4b4 Compare November 15, 2023 05:10

ldlac closed this Nov 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Camera settings #42

add Camera settings #42

ldlac commented Apr 5, 2023

ldlac Apr 5, 2023

kekyo Jun 9, 2023

kekyo commented Apr 6, 2023

ldlac commented Apr 6, 2023

ldlac commented Apr 6, 2023

kekyo commented Apr 7, 2023 •

edited

Loading

ldlac Apr 7, 2023

ldlac Apr 12, 2023

kekyo Apr 14, 2023

kekyo Apr 14, 2023

kekyo Apr 19, 2023

ldlac Apr 22, 2023

ldlac Apr 7, 2023

kekyo Apr 19, 2023

ldlac Apr 7, 2023

ldlac Apr 7, 2023

kekyo Apr 19, 2023

ldlac Apr 7, 2023 •

edited

Loading

kekyo Jun 9, 2023

ldlac Apr 7, 2023

kekyo Jun 9, 2023

ldlac Apr 7, 2023

kekyo Jun 9, 2023

kekyo commented Apr 11, 2023

ldlac Apr 22, 2023

kekyo Apr 22, 2023

add Camera settings #42

add Camera settings #42

Conversation

ldlac commented Apr 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kekyo commented Apr 6, 2023

ldlac commented Apr 6, 2023

ldlac commented Apr 6, 2023

kekyo commented Apr 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ldlac Apr 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kekyo commented Apr 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kekyo commented Apr 7, 2023 •

edited

Loading

ldlac Apr 7, 2023 •

edited

Loading