WIP: add hotfix for composing class computed #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, unfortunately my complex app still has problems with this branch. I'll have to create a local copy of the twiddle to see if the simple repro has the problem to make sure. |
|
If you could somehow submit one or many failing tests of your cases, that would be perfect for me to fix it. |
|
I'll see if I can make an acceptance test on ember-awesome-macros that mirrors the twiddle. |
kellyselden
force-pushed
the
composing-class-computed
branch
from
2ae71b4
to
8c1b022
Compare
kellyselden
force-pushed
the
composing-class-computed
branch
from
8c1b022
to
2335019
Compare
kellyselden
force-pushed
the
composing-class-computed
branch
from
2335019
to
ad72b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes kellyselden/ember-awesome-macros#407.
@jlami If you pin ember-macro-helpers to this branch, does it fix it for you?