Map country areas and makes map points optional if country is used #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodeKrakken
approved these changes
Aug 13, 2024
| }; | ||
|
|
||
| // In-memory cache for country GeoJSON data | ||
| countryCache: { [key: string]: any } = {}; |
There was a problem hiding this comment.
Do we need to use an any here?
There was a problem hiding this comment.
The object is being mutated, so I instinctively typed it as 'any' to avoid any issues. A different format could be possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Map block able to accept a "country" property in the array of map points it processes, that show as an area, the values must be 3 letter ISO country codes.
Shading for area can be adjusted.
Custom map pin points may be set to an emoji flag.
Documentation has been removed from this branch.
A unit tests file for the block was added but is removed from this branch.
This should meet requirements for: #483
To help deliver the code changes faster for Donald to use from main, my existing pull request which code, tests and documentation are to be broken up, with these code changes to be pursued first. The rest need doing for this issue: #488