Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Gosub and Reference #499

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Update documentation for Gosub and Reference #499

merged 4 commits into from
Nov 21, 2024

Conversation

gsambrotta
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kendraio-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:47am

lukestanley
lukestanley reviewed Nov 12, 2024
View reviewed changes
docs/testing/tips.rst Outdated Show resolved Hide resolved
lukestanley
lukestanley requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@lukestanley lukestanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions.

CodeKrakken
CodeKrakken requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@CodeKrakken CodeKrakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one suggestion.

docs/workflow/blocks/context_block.rst Outdated Show resolved Hide resolved
@gsambrotta gsambrotta force-pushed the gosub-ref-docu-update branch from c384f4b to 6dfa76e Compare November 12, 2024 19:42
@gsambrotta
Copy link
Collaborator Author

@lukestanley @CodeKrakken I merge in your suggestions.
Can you please have a look again? thanks

CodeKrakken
CodeKrakken approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@CodeKrakken CodeKrakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems here.

@lukestanley
Copy link
Member

@lukestanley @CodeKrakken I merge in your suggestions.
Can you please have a look again? thanks

There's a lot of commits, I think they need squashing!
@gsambrotta

@gsambrotta @lukestanley
fix several typos and grammar improvements
be64210 
Co-authored-by: Luke Stanley <[email protected]>

Co-authored-by: Luke Stanley <[email protected]>

Co-authored-by: Luke Stanley <[email protected]>

Co-authored-by: Luke Stanley <[email protected]>

Co-authored-by: Luke Stanley <[email protected]>
@gsambrotta gsambrotta force-pushed the gosub-ref-docu-update branch from b213877 to be64210 Compare November 14, 2024 12:49
@gsambrotta
Copy link
Collaborator Author

@lukestanley here you go

lukestanley
lukestanley approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@lukestanley lukestanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 👍

@gsambrotta gsambrotta merged commit c09fe57 into develop Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeKrakken CodeKrakken CodeKrakken approved these changes

@lukestanley lukestanley lukestanley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsambrotta @lukestanley @CodeKrakken