Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use non-deprecated modules and to use python3 #73

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

kentikethan
Copy link
Contributor

update to use non-deprecated modules and to use python3

also added an override for the tvars so users could create local tvar files with their creds without worrying about them going to the repo

@jryburn jryburn self-requested a review February 15, 2024 23:00
jryburn
jryburn previously approved these changes Feb 15, 2024
Copy link

@jryburn jryburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There is a check failing but it's not for the areas of code that @kentikethan touched.

Copy link

@jryburn jryburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and should keep the Ansible test from failing which is not relevant to this PR.

@i3149 i3149 merged commit 6897321 into master Feb 17, 2024
17 checks passed
@i3149 i3149 deleted the update_for_single_account_2024 branch February 17, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants