Skip to content

Commit

Permalink
Improvements for gutters and line numbers in popovers
Browse files Browse the repository at this point in the history
  • Loading branch information
kepano committed Aug 9, 2024
1 parent 632849d commit ea8e271
Show file tree
Hide file tree
Showing 10 changed files with 63 additions and 9 deletions.
20 changes: 19 additions & 1 deletion Minimal.css
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,16 @@ body :not(.canvas-node) .markdown-source-view.mod-cm6 .cm-gutters {
z-index: 0;
margin-inline-end: 0;
}
body :not(.canvas-node) .markdown-source-view.mod-cm6 .cm-gutters .cm-gutter:before {
content: "";
height: 100%;
top: -100%;
width: 100%;
position: absolute;
z-index: 1;
background-color: var(--gutter-background);
min-width: var(--folding-offset);
}

body :not(.canvas-node) .markdown-source-view.mod-cm6.is-rtl .cm-gutters {
right: 0;
Expand Down Expand Up @@ -1337,7 +1347,14 @@ button.mod-warning:hover {
}

.popover {
--file-margins: var(--size-4-4) var(--size-4-6) var(--size-4-6);
--file-margins: var(--size-4-6) var(--size-4-6) var(--size-4-6);
}

.minimal-line-nums .popover .markdown-source-view {
--file-margins: var(--size-4-4) var(--size-4-6) var(--size-4-6) var(--size-4-12);
}
.minimal-line-nums .popover .markdown-source-view.is-rtl {
--file-margins: var(--size-4-4) var(--size-4-12) var(--size-4-6) var(--size-4-6);
}

/* Progress bars */
Expand Down Expand Up @@ -9222,6 +9239,7 @@ settings:
title: Gutter background
type: variable-themed-color
format: hex
opacity: true
default-light: '#'
default-dark: '#'
-
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Minimal",
"version": "7.7.13",
"version": "7.7.14",
"minAppVersion": "1.6.1",
"author": "@kepano",
"authorUrl": "https://twitter.com/kepano",
Expand Down
19 changes: 18 additions & 1 deletion src/css/main.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/css/main.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/css/main.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/css/main.min.css.map

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/css/style-settings.css
Original file line number Diff line number Diff line change
Expand Up @@ -1185,6 +1185,7 @@ settings:
title: Gutter background
type: variable-themed-color
format: hex
opacity: true
default-light: '#'
default-dark: '#'
-
Expand Down
11 changes: 10 additions & 1 deletion src/scss/app/editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,16 @@ body :not(.canvas-node) .markdown-source-view.mod-cm6 .cm-gutters {
position:absolute !important;
z-index:0;
margin-inline-end: 0;

.cm-gutter:before {
content: "";
height: 100%;
top: -100%;
width: 100%;
position: absolute;
z-index: 1;
background-color: var(--gutter-background);
min-width: var(--folding-offset);
}
}
body :not(.canvas-node) .markdown-source-view.mod-cm6.is-rtl .cm-gutters {
right: 0;
Expand Down
10 changes: 9 additions & 1 deletion src/scss/components/popovers.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
.popover {
--file-margins: var(--size-4-4) var(--size-4-6) var(--size-4-6);
--file-margins: var(--size-4-6) var(--size-4-6) var(--size-4-6);
}
.minimal-line-nums {
.popover .markdown-source-view {
--file-margins: var(--size-4-4) var(--size-4-6) var(--size-4-6) var(--size-4-12);
}
.popover .markdown-source-view.is-rtl {
--file-margins: var(--size-4-4) var(--size-4-12) var(--size-4-6) var(--size-4-6);
}
}
3 changes: 2 additions & 1 deletion theme.css

Large diffs are not rendered by default.

0 comments on commit ea8e271

Please sign in to comment.