[Feat] Kepler.gl AI Assistant #2735
Conversation
❌ Deploy Preview for keplergl2 failed. Why did it fail? →
|
|
@lixun910 Very cool. There are a couple of things that need to be discussed, good if we can connect on slack for the first alignment. |
There was a problem hiding this comment.
This is very exciting.
My personal take is that it would be good to separate out the AI integration more clearly.
At the extreme end, it could go into its own top-level module (@kepler.gl/ai-assistant), but at minimum, having a clearly separated integration code that is not located inside UI glued code like components, hooks, reducers.
Of course we can refine that step-by-step, so approving for now.
src/types/reducers.d.ts
Outdated
| @@ -576,3 +577,13 @@ export type TypedFilter = | |||
| | TypedSelectFilter | |||
| | TypedMultiSelectFilter | |||
| | TypedPolygonFilter; | |||
|
|
|||
| export type AiAssistantConfig = { | |||
There was a problem hiding this comment.
I though we had merged all d.ts files into .ts...
There was a problem hiding this comment.
Nit: For new types, could we add TSDoc /** */ comments on the type and each field (this integrates into vscode intellisense).
Especially fields like temperature and topP - maybe not instantly clear what they are used for?
| @@ -201,7 +201,9 @@ export default { | |||
| delete: 'Deletar', | |||
| timePlayback: 'Tempo de reprodução', | |||
| cloudStorage: 'Armazenamento Cloud', | |||
| '3DMap': ' Mapa 3D' | |||
| '3DMap': ' Mapa 3D', | |||
| showAiAssistantPanel: 'Mostrar Assistente IA', | |||
There was a problem hiding this comment.
Q: Did you use AI to translate the AI settings :)
| import {MapControlButton} from '../common/styled-components'; | ||
| import MapControlTooltipFactory from './map-control-tooltip'; | ||
|
|
||
| interface AiAssistantControlIcons { |
There was a problem hiding this comment.
Nit: Any reason to use interface instead of type here, you seem to be mixing them.
There was a problem hiding this comment.
Add TSDoc /** */ on the line before each new type and field? Costs little and integrates with vscode.
| import { appInjector } from '../container'; | ||
| import { MapStyle } from '@kepler.gl/reducers'; | ||
|
|
||
| export function basemapFunctionDefinition( |
There was a problem hiding this comment.
is this the actual integration? I am not sure we should have that mixes with React and state management... it would be good to have clear separation.
|
woohoo, awesome stuff! |
|
@igorDykhta Hi Igor, do you have any suggestions on why the netlify build failed: https://app.netlify.com/sites/keplergl/deploys/67390c9f870e2b0008a92487 Thank you! |
Have you tried updating yarn.lock? |
Thanks, Igor! Yes, I did. Is this causing the compiling error? |
Do you have access to the failing Netlify Deploy log? |
I think I figure it out: there are two yarn.lock files need to be updated. Thanks, Igor! |
|
init work done
|
| @@ -197,7 +200,7 @@ | |||
| "tape": "^4.9.2", | |||
| "tape-catch": "^1.0.6", | |||
| "typedoc-plugin-markdown": "^3.0.11", | |||
| "typescript": "4.5.5", | |||
| "typescript": "4.7.2", | |||
There was a problem hiding this comment.
support latest langchain
This is a WIP pr that tries to add AI Assistant which was originally developed for https://geoda.ai and now is open sourced and available to use.