fix!: update for compatibility with the new async APIs in Prettier 3 #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
commented
Aug 23, 2023
| @@ -19,7 +19,7 @@ | |||
| "prepare": "husky install" | |||
| }, | |||
| "lint-staged": { | |||
| "*": "node --experimental-vm-modules node_modules/jest/bin/jest.js --bail --findRelatedTests" | |||
| "src/*": "node --experimental-vm-modules node_modules/jest/bin/jest.js --bail --findRelatedTests" | |||
There was a problem hiding this comment.
Otherwise this thing will try to run tests against package.json et al.
steveluscher
commented
Aug 23, 2023
| }, | ||
| "overrides": { | ||
| "eslint-config-starstuff": { | ||
| "eslint-plugin-prettier": "^5.0.0" |
There was a problem hiding this comment.
You may like to, instead, release a new major version of starstuff that's Prettier 3 compatible.
|
I forgot that I'd done this, discovered that our Prettier tests weren't doing anything, debugged the root cause, and then rediscovered this. Any chance you'd like to crush out a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
peerDependenciesversion of Prettier to >=3This is a breaking version that will require a major version bump.
Fixes #586.