Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-44 remove/replace headers while recording tc #47

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shreyanshshah27
Copy link

@shreyanshshah27 shreyanshshah27 commented Feb 23, 2023

@re-Tick
Copy link
Contributor

re-Tick commented Mar 1, 2023

Hi @shreyanshshah27, please make changes for mock library to remove and replace fields

Signed-off-by: Shreyansh Shah <[email protected]>
@shreyanshshah27
Copy link
Author

Hey @re-Tick

Please review the PR, I've made the required changes in mock library to support this feature.

mock/mock.ts Outdated
@@ -71,6 +73,8 @@ export function NewContext(conf: Config) {
testId: conf.Name,
mocks: [],
fileExport: true,
Remove: conf.Remove,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Remove and Replace should be added in record mode. Since we filtering during recording.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I've fixed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Shreyansh Shah <[email protected]>
@re-Tick re-Tick added gsoc Google Summer of Code Don't Merge Not to be merged until gsoc results Accepted PR is reviewed and Accepted labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results gsoc Google Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: add a filter for request header fields
2 participants