feat(mock.ts, keploy.ts, client.ts): Adding Keploy Mode in logs to no… #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Hermione2408, we just need to log mode only once which could be from src/keploy.go and mock/mock.go This console statements can be in the constructor of Keploy class. |
Hermione2408
force-pushed
the
feature/gh-45
branch
from
0085783
to
1278a4f
Compare
re-Tick
reviewed
Mar 2, 2023
mock/mock.ts
Outdated
| @@ -27,6 +27,7 @@ export interface Config { | |||
| Mode: string; | |||
| } | |||
| export function NewContext(conf: Config) { | |||
| console.log("Keploy running in: ",process.env.KEPLOY_MODE," mode"); | |||
There was a problem hiding this comment.
Please place this log statement after this because here we are considering mode either from env variable or conf.mode parameter. Also log value of "mode" in log statement instead of process.env
…tify user Adding Keploy mode in logs to notify user in which mode keploy is running whether it is record, test, off feat #45 Signed-off-by: Hermione Dadheech <[email protected]>
feat #45 Signed-off-by: Hermione Dadheech <[email protected]>
feat #45 Signed-off-by: Hermione Dadheech <[email protected]>
Hermione2408
force-pushed
the
feature/gh-45
branch
from
e8a3620
to
1ad2d59
Compare
|
LGTM. Hey @Hermione2408 , Please add link to this PR in GSOC/2023 Task List . |
|
Done. |
re-Tick
added
good first issue
re-Tick
added
Accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Keploy mode in logs to notify user in which mode keploy is running whether it is record, test, off
feat keploy/keploy#390
Closes: keploy/keploy#390