add interceptor for http clients #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramanjs <[email protected]>
|
@re-Tick Can you please review this? |
|
Hi @Ramanjs, the structure looks good to me. We have to pass the ctx to the ProcessDep as an argument to mock/capture the outputs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @re-Tick, I was thinking about the process to intercept all HTTP requests, so I wrote up a quick prototype of how we could do this using @mswjs/interceptors package by reusing code from the node-fetch integration. It is intercepting and recording mocks for Axios but has a little problem in converting the response body readable stream to string right now. I'll try to figure that part out, but what do you think about the overall structure?