To start keploy server from typescript sdk for all OS #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To start keploy server from typescript sdk for all OS. feat #352 Signed-off-by: Hermione Dadheech <[email protected]>
Added additional check for error code and will also start the server in that case too feature #352 Signed-off-by: Hermione Dadheech <[email protected]>
|
@re-Tick Can you please review this PR? |
|
When I try the changes with a sample application, the following error is thrown: |
|
I am checking why it is happening |
|
@re-Tick error is occurring because when there is nothing running on port 6789 , empty output is treated as an error and hence the error is shown, I have added additional check for the error code and will also start the server in that case too |
|
@Hermione2408 changes are working locally. LGTM. |
re-Tick
added
Don't Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To start keploy server from typescript sdk for all OS.
feat keploy/keploy#352