Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Hero Image Not Responsive on Mobile #10

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

shreyashrpawar
Copy link
Contributor

@shreyashrpawar shreyashrpawar commented Jul 18, 2024

Pull Request Template

Description

KROC leaderboard PR #18

The Hero image is aligning with other elements on mobile devices. So used the css queries to solve this issue.

Fixes #8

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested the change on the mobile device itself. So, the issue will be solved effectively.

Additional Context (Please include any Screenshots/gifs if relevant)

Visible page on mobile:
keploy's writers

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in writers-program

@shreyashrpawar shreyashrpawar changed the title [Bug]: Hero Image Not Responsive on Mobile #1537 [Bug]: Hero Image Not Responsive on Mobile Jul 18, 2024
Copy link
Contributor

@Swpn0neel Swpn0neel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But it would be nice if you could share a short video by demonstrating that it's now fully responsive, using the developer tools!

@shreyashrpawar
Copy link
Contributor Author

Here is the short video demonstrating that it's now fully responsive.

keploy.recording.mp4

@Swpn0neel Kindly check it now

@Swpn0neel
Copy link
Contributor

Great! Kindly fix the DCO check:

@shreyashrpawar
Copy link
Contributor Author

shreyashrpawar commented Jul 18, 2024

@Swpn0neel Thanks. Fixed the DCO check

@shreyashrpawar
Copy link
Contributor Author

KROC leaderboard PR #18

@Swpn0neel Swpn0neel requested a review from Sonichigo July 18, 2024 17:50
@Swpn0neel Swpn0neel merged commit 51ec02a into keploy:main Jul 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idc
2 participants