Add username to get account #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahme-dev
changed the title
ahme-dev
commented
Jan 27, 2025
Comment on lines
+9
to
+14
| type AccountGetterParams struct { | ||
| AccountID *int | ||
| Username *string | ||
| } | ||
|
|
||
| func AccountGetter(store data.AccountStore, params AccountGetterParams) (*models.Account, error) { |
There was a problem hiding this comment.
Haven't seen structs used for params, so let me know if this should be changed
cainlevy
requested changes
Feb 5, 2025
| if err != nil { | ||
| if _, ok := err.(services.FieldErrors); ok { | ||
| WriteNotFound(w, "account") |
There was a problem hiding this comment.
Can you say more about this change? I'm not sure how it's related.
There was a problem hiding this comment.
I've commited it by mistake, re-adding now. Let me know if there's anything else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to get an account by username, alongside the normal id. As discussed in #264