Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if device is nil, if so do not proceed (avoic panic) #151

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Jan 3, 2025

This pull request includes an important change to the machinery/src/onvif/main.go file to improve error handling in the CreatePullPointSubscription function. The most significant change is the addition of a check to ensure the dev parameter is not nil before proceeding with the method call.

Error handling improvement:

  • machinery/src/onvif/main.go: Added a nil check for the dev parameter in the CreatePullPointSubscription function to return an error if dev is nil, preventing potential runtime errors when the device is not connected.

@cedricve cedricve merged commit 4fde419 into master Jan 6, 2025
9 checks passed
@cedricve cedricve deleted the fix/pullpoint-crash branch January 6, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant