LoongArch: BPF: Sign-extend return values #4681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 2c8b09a |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
a2b6898 to
144e0d4
Compare
|
Upstream branch: 2c8b09a |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
1861d22 to
0dde1fc
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
144e0d4 to
f6e803b
Compare
|
Upstream branch: 2c8b09a |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
0dde1fc to
ed50427
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
f6e803b to
a034f30
Compare
|
Upstream branch: fc39fb5 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
ed50427 to
8435361
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
a034f30 to
70d7319
Compare
|
Upstream branch: fc39fb5 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
8435361 to
74d38c6
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
70d7319 to
125061d
Compare
|
Upstream branch: fc39fb5 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
74d38c6 to
e908186
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
125061d to
4d44a3a
Compare
|
Upstream branch: 28eb75e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
e908186 to
906c4e3
Compare
|
Upstream branch: 28eb75e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
906c4e3 to
2d57388
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4d44a3a to
a3eb926
Compare
(1) Description of Problem:
When testing BPF JIT with the latest compiler toolchains on LoongArch,
there exist some strange failed test cases, dmesg shows something like
this:
# dmesg -t | grep FAIL | head -1
... ret -3 != -3 (0xfffffffd != 0xfffffffd)FAIL ...
(2) Steps to Reproduce:
# echo 1 > /proc/sys/net/core/bpf_jit_enable
# modprobe test_bpf
(3) Additional Info:
There are no failed test cases compiled with the lower version of GCC
such as 13.3.0, while the problems only appear with higher version of
GCC such as 14.2.0.
This is because the problems were hidden by the lower version of GCC
due to there are redundant sign extension instructions generated by
compiler, but with optimization of higher version of GCC, the sign
extension instructions have been removed.
(4) Root Cause Analysis:
The LoongArch architecture does not expose sub-registers, and hold all
32-bit values in a sign-extended format. While BPF, on the other hand,
exposes sub-registers, and use zero-extension (similar to arm64/x86).
This has led to some subtle bugs, where a BPF JITted program has not
sign-extended the a0 register (return value in LoongArch land), passed
the return value up the kernel, for example:
| int from_bpf(void);
|
| long foo(void)
| {
| return from_bpf();
| }
Here, a0 would be 0xffff_ffff, instead of the expected
0xffff_ffff_ffff_ffff.
Internally, the LoongArch JIT uses a5 as a dedicated register for BPF
return values. That is to say, the LoongArch BPF uses a5 for BPF return
values, which are zero-extended, whereas the LoongArch ABI uses a0 which
is sign-extended.
(5) Final Solution:
Keep a5 zero-extended, but explicitly sign-extend a0 (which is used
outside BPF land). Because libbpf currently defines the return value
of an ebpf program as a 32-bit unsigned integer, just use addi.w to
extend bit 31 into bits 63 through 32 of a5 to a0. This is similar
with commit 2f1b0d3 ("riscv, bpf: Sign-extend return values").
Fixes: 5dc6155 ("LoongArch: Add BPF JIT support")
Signed-off-by: Tiezhu Yang <[email protected]>
Acked-by: John Fastabend <[email protected]>
|
Upstream branch: 9f16d5e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/910839=>bpf-next
branch
from
2d57388 to
a610ff9
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=910839 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: LoongArch: BPF: Sign-extend return values
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=910839