Do not check for ID in the device name #23
Conversation
The ID used in the device name for cros-ec drivers keeps changing and has no gaurantee to remain stable accross different kernel versions. Hence, do not check for ID in the device name. Signed-off-by: Shreeya Patel <[email protected]>
staging-kernelci-org
force-pushed
the
staging.kernelci.org
branch
from
489b30a
to
d5b3924
Compare
staging-kernelci-org
force-pushed
the
staging.kernelci.org
branch
5 times, most recently
from
11d19f3
to
716dbc3
Compare
Remove rockchip-i2s1-probed test and add a new rockchip-spdif1-probed test as per the kernel changes from v5.18. Signed-off-by: Shreeya Patel <[email protected]>
|
@hardboprobot can you please review these patches. It's just a simple fix which should work for now. I think more future-proof solution would be to use the firmware ID + driver name of the devices but that will require a lot of changes to the file and can be applied on other board files too. It is really not required to make big changes to the file currently imo. |
staging-kernelci-org
force-pushed
the
staging.kernelci.org
branch
3 times, most recently
from
cb7bba1
to
278ce61
Compare
staging-kernelci-org
force-pushed
the
staging.kernelci.org
branch
2 times, most recently
from
49b1738
to
3d870e9
Compare
| fi | ||
|
|
||
| assert_device_present cros-ec-sensors-accel0-probed cros-ec-sensors cros-ec-accel.* |
There was a problem hiding this comment.
The issue with this is that there are multiple (2) files that will match the cros-ec-accel.* glob. So assert_device_present will see each of them as a different parameter. The first will be used as it's supposed to, but the second will be passed to the timeout command, which I think will cause an error. So the * globbing can only be used in the bootrr commands when it matches a single file (which is why I couldn't have #40 be a single check).
There was a problem hiding this comment.
How about fixing that in assert_device_present? Example: r-c-n@50a07b2
I guess this can be extended to other helpers.
There was a problem hiding this comment.
@hardboprobot sounds sensible to me, the only thing I'm not sure about is requiring bash instead of sh. But if you could create a PR we can discuss/test it further there.
There was a problem hiding this comment.
Ugh I didn't get a notification for this, sorry. PR: #41
staging-kernelci-org
force-pushed
the
staging.kernelci.org
branch
from
3d870e9
to
3ae9fd5
Compare
The ID used in the device name for cros-ec drivers keeps changing and has no guarantee to remain stable across different kernel versions. Hence, do not check for ID in the device name.
Signed-off-by: Shreeya Patel [email protected]