Up2023.10 #174
Merged
Up2023.10 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no master exists, lavalab-gen.py fail, so found the right master.
ser2net could be on a different host than where lava-worker ran. So add a worker: option to permit to specify where it is. Signed-off-by: Corentin LABBE <[email protected]>
The migration bug is handled only when upgrading to 2023.06. But some users will migrate also to 2023.08/2023.10, let's handle this. Signed-off-by: Corentin LABBE <[email protected]>
Permit the device-type loop to be faster by caching the device-type list. This also remove a crash when the call is inside the loop. I dont find the reason of this crash, but it works now. Signed-off-by: Corentin LABBE <[email protected]>
Since LAVA does not use zmq, lot of ports are now unnecessary to export. Signed-off-by: Corentin LABBE <[email protected]>
If lava-docker is used with an apache in proxy mode, permit to restrict it on a specific address (like localhost) Signed-off-by: Corentin LABBE <[email protected]>
Signed-off-by: Corentin LABBE <[email protected]>
patersonc
reviewed
Nov 10, 2023
| @@ -344,6 +344,7 @@ boards: | |||
| devpath: the UDEV devpath to this uart for UART without serial number | |||
| interfacenum: (optional) The interfacenumber of the serial. (Used with two serial in one device) | |||
| use_ser2net: True/False (Deprecated, ser2net is the default uart handler) | |||
| worker: (optional) an host/IP where ser2net is running | |||
There was a problem hiding this comment.
Would this be better as ser2net_worker as it's specifically for ser2net, like the other variables below?
Obviously lavalab-gen.py would need updating accordingly.
There was a problem hiding this comment.
It could be used for other purpose, with labgrid ser2net will be not used, but this information remains the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to 2023.10 and add some security by closing some unnecessary ports