Merge pull request #716 from rical/fix-confd-cont-double-free

confd: fix double free of container hostname
kernelkit · Oct 16, 2024 · 08348c4 · 08348c4
2 parents 0e276a9 + 3b4d2b3
commit 08348c4
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/confd/src/infix-containers.c b/src/confd/src/infix-containers.c
@@ -52,12 +52,10 @@ static int add(const char *name, struct lyd_node *cif)
 	if ((string = lydx_get_cattr(cif, "hostname"))) {
 		char *fmt = (char *)string;
 
-		if (hostnamefmt(&confd, &fmt)) {
+		if (hostnamefmt(&confd, &fmt))
 			ERRNO("%s: failed setting custom hostname", name);
-		} else {
+		else
 			fprintf(fp, " --hostname %s", fmt);
-			free(fmt);
-		}
 	}
 
 	if (lydx_is_enabled(cif, "read-only"))