Use consistent confd timeout value from all front-ends #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While sysrepo's architecture places the responsibility of choosing a timeout on each front-end, we want to control it centrally since the majority of the time is spend actually applying the config to the system - which is front-end agnostic. Therefore, create a single definition of the timeout, which can be included by all front-ends.
This will enable us to align this timeout with the other front-ends in the system.
Now that we have a unified timeout value that all front-ends should honor, make sure to do so when loading startup-config and failure-config during boot. This fixes an issue where the system would fallback to failure-config even though a legitimate startup-config was available, but took more than 10s to apply.
wkz
force-pushed
the
startup-cfg-timeout
branch
from
62aa8bb
to
08bbc0e
Compare
wkz
requested review from
troglobit and
mattiaswal
and removed request for
troglobit
mattiaswal
approved these changes
Sep 5, 2024
troglobit
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where the system would fallback to
failure-configeven though a legitimatestartup-configwas available, but took more than 10s to apply.Accomplish this by making sure that there is only a single definition of
confd's timeout value, and use it in all front-ends.Checklist
Tick relevant boxes, this PR is-a or has-a: