Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #629

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Misc fixes #629

merged 6 commits into from
Sep 17, 2024

Conversation

mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Sep 13, 2024 •
edited
Loading

Description

Other information

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

troglobit
troglobit requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup work! ✨

doc/ChangeLog.md Outdated Show resolved Hide resolved
doc/developers-guide.md Outdated Show resolved Hide resolved
src/confd/yang/[email protected] Outdated Show resolved Hide resolved
@mattiaswal mattiaswal force-pushed the fix-test-texts branch 5 times, most recently from 67f745c to 13341a4 Compare September 16, 2024 12:31
@mattiaswal
test: infamy: Make possible to override username and password
7042636 
This is now possible for SSH/RESTCONF/NETCONF, most useful with
SSH and adding/modify users.
@mattiaswal mattiaswal force-pushed the fix-test-texts branch 2 times, most recently from 2a05b3c to a565d29 Compare September 16, 2024 18:29
@mattiaswal
test: case: ietf_system: Update test texts
5dead67 
And some changes in test semantics.
@mattiaswal
Remove silent lock for login shell bash/sh on non-admin users
552acbd 
Added some security information in YANG model, and it is now
up to the system administrator to handle potential security
issues.

This fix #616
@mattiaswal
doc: develop: Add autoconf and automake as requirement
9e884b4
@mattiaswal
test: case: Update some toplogy PNG files
fc4eb77
@mattiaswal
test: case: Move infix_interfaces into ietf-interfaces
c1093e6 
This is how all other models are handled, the topmodel is naming the
test directory
troglobit
troglobit approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattiaswal mattiaswal merged commit a533b87 into main Sep 17, 2024
4 checks passed
@mattiaswal mattiaswal deleted the fix-test-texts branch September 17, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silent failure when selecting bash as login shell for non-admin user
2 participants
@mattiaswal @troglobit