Fix test issues after adding veth-delete test #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkz
approved these changes
Sep 27, 2024
Fixes to following exception calling iface.interface_exist(target, veth0): requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://[fe80::2a0:85ff:fe00:201%d2a]:443/restconf/ds/ietf-datastores%3Aoperational/ietf-interfaces%3Ainterfaces/interface=veth0a/name Removing interface veth0a, and then checking operational if it has been properly removed, should not cause an exception. Better to return None object instead. Signed-off-by: Joachim Wiberg <[email protected]>
Refactor 0f9d429 to first check if the .cfg file has any routing protocol active before converting the type's value. This fixes a regression in the release cycle that otherwise would cause a fresh startup-config, created from a plain factory-config from v24.08, to be converted to an empty file. Inspired by this fix, the same mitigation, albeit highyl unlikely, has been applied to the v1.0 user shell type migration. Signed-off-by: Joachim Wiberg <[email protected]>
Introduced in 35eeae5. Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
force-pushed
the
veth-delete
branch
from
652f1e7
to
0159462
Compare
Signed-off-by: Joachim Wiberg <[email protected]>
mattiaswal
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mainwhile fixing issue confd: fails removing veth pair after a multple reconfigurations #658control-plane-protocolinstartup-configbefore migrating and causing emptystartup-configNoneon 404 return for fetching a given operational XPath in RESTCONF test backendtcpdumppermissions foradminuser in CLIChecklist
Tick relevant boxes, this PR is-a or has-a: