Support downloading artifacts from release builds #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the assumption was that the artifact could be found in the first run of "Bob the Builder". This does not hold in the case when: 1. An initial run is aborted, and is re-run at a later date 2. When a release is built (by "Release General")
Release tarball names contain the version information. Make sure we find these files when extracting them from the artifact ZIP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
gh-dl-artifactscript is now able to find artifacts in any run associated with a particular commit, and if the one it finds is the result of a release build, that is now correctly extracted.Checklist
Tick relevant boxes, this PR is-a or has-a: