Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some tests #692

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Update some tests #692

merged 4 commits into from
Oct 10, 2024

Conversation

mattiaswal
Copy link
Contributor

Fix typos and improve some test coverage

Description

Other information

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@mattiaswal mattiaswal force-pushed the update-tests branch 4 times, most recently from 0c93c57 to ae4dca0 Compare October 9, 2024 10:36
@troglobit troglobit added this to the Infix v24.10 milestone Oct 9, 2024
troglobit
troglobit approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

we'll get a conflict in iface_phys_address tho ... 🙄

@mattiaswal
tests: Update some typos in test steps
00b103d 
Also add missing ipv4_autoconf test from specification
@mattiaswal
test: ospf_multiarea: Test interface type point-to-point and router-id
02100ef 
Test point-to-point on /30-links, verify the interface type
set explicit-router-id and verify that it gets set and sent
over OSPF.
@mattiaswal
test: add_delete_user: Test yescrypt
c0d5bfa
@mattiaswal
confd: ietf-system: Add missing endspent() when getting operational data
f1d7304 
This fix #697
@mattiaswal mattiaswal merged commit dc0a68a into main Oct 10, 2024
6 checks passed
@mattiaswal mattiaswal deleted the update-tests branch October 10, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees

@mattiaswal mattiaswal

Labels
None yet
Projects
Infix & C:o
Status: Done
Milestone
Infix v24.10
Development

Successfully merging this pull request may close these issues.
2 participants
@mattiaswal @troglobit