Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify fetching data using ssh public key #693

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Verify fetching data using ssh public key #693

merged 1 commit into from
Oct 10, 2024

Conversation

axkar
Copy link
Collaborator

@axkar axkar commented Oct 9, 2024

Add a test case to verify that a new (guest) user can retrieve data (i.e syslog data) using ssh public key.

Fixes #304

Description

Other information

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@axkar axkar requested a review from troglobit October 9, 2024 08:03
@axkar axkar self-assigned this Oct 9, 2024
@troglobit troglobit added this to the Infix v24.10 milestone Oct 9, 2024
troglobit
troglobit approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real good, but I'd like you to squash your two commits into one. The other comments are only suggestions 😃

test/case/ietf_system/ssh_key_authentication/test.py Outdated Show resolved Hide resolved
test/case/ietf_system/ssh_key_authentication/test.py Outdated Show resolved Hide resolved
test/case/ietf_system/ssh_key_authentication/test.py Outdated Show resolved Hide resolved
@troglobit troglobit self-requested a review October 9, 2024 14:45
troglobit
troglobit requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry, clicked the wrong radio button, I do want you to squash first, and at least add that TODO: comment :)

@axkar
test: Verify fetching data using ssh public key
b1bc7b4 
Add a test case to verify that a new (guest) user can retrieve data
(i.e. syslog data) using ssh public key

Fixes #304
@axkar
Copy link
Collaborator Author

axkar commented Oct 9, 2024

Thnx for the comments :) Hope it looks better now. Feel free to request another update :)

@axkar axkar requested a review from troglobit October 9, 2024 17:22
troglobit
troglobit approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great job! 💪😎

@axkar axkar merged commit c44621b into main Oct 10, 2024
6 checks passed
@axkar axkar deleted the verify-ssh-key branch October 10, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees

@axkar axkar

Labels
None yet
Projects
Infix & C:o
Status: Done
Milestone
Infix v24.10
Development

Successfully merging this pull request may close these issues.

test: verify SSH public key authentication
2 participants
@axkar @troglobit