Custom MAC address #695
Merged
Custom MAC address #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
added
documentation
wkz
reviewed
Oct 10, 2024
troglobit
force-pushed
the
custom-phys-address
branch
3 times, most recently
from
e9fe3e5
to
2d788e7
Compare
wkz
approved these changes
Oct 11, 2024
doc/img/lego-relations.svg
Outdated
There was a problem hiding this comment.
Great way to align the image to the new text!
...I just noticed that the IP address attached to that Ethernet interface, although accepted by the kernel, will never behave as the user expects. Except for the traffic assigned to any of the two VLAN interfaces, all packets will be sent directly to the bridge; go not pass the IP stack; do not collect $400 😄
There was a problem hiding this comment.
Thanks for noticing, that could've been a source of much confusion for us and users 🤣
troglobit
force-pushed
the
custom-phys-address
branch
from
2d788e7
to
9f27bb4
Compare
This commit replaces the ietf-interfaces deviation for phys-address, used to set custom MAC address on interfaces, with a more flexible approach which can calculate the new MAC address based on the device's chassi MAC, with or without an added offset. The regression test has been updated to test all variants. Resolves: #680 Signed-off-by: Joachim Wiberg <[email protected]>
See issue #680 Signed-off-by: Joachim Wiberg <[email protected]>
This patch relocates the 30-cfg-migrate init script to confd, where it
belongs, renaming it migrate and installing into /usr/sbin.
The script has been heavily modified to be more user friendly, as well
as useful for automated restore operations, to be able to refresh old
backups to modern .cfg file syntax.
Example (injected phys-address error):
admin@example:~$ migrate -c /etc/factory-config.cfg
/etc/factory-config.cfg: has syntax error, requires migrating.
Since backups are created with the old confd sytanx version in the name,
the backup functionality has been kept in the script.
Signed-off-by: Joachim Wiberg <[email protected]>
For products with a static factory-config, or customers generating with an older syntax, attempt migration in case of bootstrap failure. Refactor logging to drop '-s'. This prevents duplicate log messages since bootstrap always runs after syslogd has started and all stdout is always logged. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Add issue #680, and all others that's gone in during the last week. Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
force-pushed
the
custom-phys-address
branch
from
9f27bb4
to
2618085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
phys-addressdeviation with newcustom-phys-address,For details, see Add custom-phys-address for interfaces #680
custom-phys-addressexamples to documentationOther information
Update documentation, networking.md:
Checklist
Tick relevant boxes, this PR is-a or has-a: