Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix too small timeout for copy command #717

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Fix too small timeout for copy command #717

merged 4 commits into from
Oct 18, 2024

Conversation

troglobit
Copy link
Contributor

@troglobit troglobit commented Oct 16, 2024 •
edited
Loading

Description

  • New: copy/erase/files stand-alone UNIX programs, from klish-plugin-infix
  • Remaining copy/erase code in klish-plugin-infix handle args. and cd $HOME
  • Also, some minor fixes to other programs

TODO: add bash completion to copy/erase and #373

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@troglobit
statd: add missing dependency
ef1b1b1 
Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
keyack: minor, whitespace and constification
886d839 
Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
bin: factor out copy, erase, and files from klish-plugin-infix
464e0bc 
Relocate C code from klish-plugin-infix to stand-alone binaries we can
use also from Bash.

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit
bin: use CONFD_TIMEOUT for all copy operations
343b453 
Fixes #701

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit troglobit added this to the Infix v24.10 milestone Oct 16, 2024
@troglobit troglobit requested a review from wkz October 16, 2024 04:15
wkz
wkz approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! ❤️

Also: great addition to get copy from the shell 👍

src/bin/util.c Show resolved Hide resolved
@troglobit troglobit mentioned this pull request Oct 18, 2024
Open
@troglobit troglobit merged commit 3bcc058 into main Oct 18, 2024
5 of 6 checks passed
@troglobit troglobit deleted the copy-timeout branch October 18, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkz wkz wkz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Infix & C:o
Status: Done
Milestone
Infix v24.10
Development

Successfully merging this pull request may close these issues.
2 participants
@troglobit @wkz