Container fixups #718
Merged
Container fixups #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expand on Docker Hello World - Add more pictures to help break up the content a bit Signed-off-by: Joachim Wiberg <[email protected]>
This refactor, and massive code simplification, is a follow-up to the double free discovery in 3b4d2b3. Beacuse a hostname in Linux can never be more than 64 chars, we can safely use a stack buffer instead of calloc(), reducing complexity and simplifying the code further with the use of strlcat(). Signed-off-by: Joachim Wiberg <[email protected]>
|
Great initiative refactoring this! Unfortunately I don't have time to review the actual code right now, but knowing its refactored will make me sleep better ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hostnamefmt(), as a follow-up toconfd: fix double free of container hostname #716
Ping @rical
Checklist
Tick relevant boxes, this PR is-a or has-a: